arch/arm: guard .thumb_func use #15897
Open
+4
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Arch: arm
acassis
approved these changes
Feb 24, 2025
jerpelea
approved these changes
Feb 24, 2025
@pkarashchenko, thanks for the comments! I thought this is only for GNU as it is under I guess we may need enlarge the guard for GHS toolchain as well, but I can't test it yet. |
This guards use of .thumb_func with ARM_THUBM kconfig so that CONFIG_ARM_THUMB can be off for cases like qemu-armv7r:pnsh Signed-off-by: Yanfeng Liu <[email protected]>
This drops forcing ARM_THUMB for ARMV7R so that downstream chips can use it optionally. Signed-off-by: Yanfeng Liu <[email protected]>
|
@xiaoxiang781216 thanks for info about GHS, it has been guarded in the latest update already. |
xiaoxiang781216
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This guards use of thumb_func with ARM_THUMB so that PROTECTED build can work in non-THUMB mode.
Impacts
arm 32 bit devices w/o ARM_THUMB can do signal handling in PROTECTED mode now.
Testing
local checks with qemu-armv7r:pnsh, qemu-armv7a:knsh with ARM_THUMB off, with apt-installed
gcc-arm-none-eabitoolchain 10.3.1 on Ubuntu 22.04.CI checks